[ 
https://issues.apache.org/jira/browse/YARN-3463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14494892#comment-14494892
 ] 

Craig Welch commented on YARN-3463:
-----------------------------------

bq. 1) Preemption policy changes seems not correct to me...
So, I believe the behavior for FIFO should be exactly as it was before - and 
all of the preemption tests were passing with the combined patch, so I think 
this is the case.  Fairness preemption would be handled on [YARN-3319].  I 
don't mind moving the final integration for preemption into another jira, but I 
don't believe the concern is correct / there is any behavioral change for FIFO.

bq. 2) WebUI, REST API and CLI changes are public APIs and related to core 
changes in CS...

There are no REST API or CLI changes in the patch anymore, we agreed on 
[YARN-3318] 
https://issues.apache.org/jira/browse/YARN-3318?focusedCommentId=14393347&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14393347
 that the WebUI changes should stay with the initial integration - it's very 
important/needed to be able to confirm that configuration was accomplished 
properly, without it there is no way to tell what policy is active.

bq. So I suggest only leave core changes for CS including configuration 

So, I think given the WebUI bit above, this is already the case, with the 
possible exception of preemption which, again, I think has not seen any 
behavior change for FIFO, which is all we have at this time.



> Integrate OrderingPolicy Framework with CapacityScheduler
> ---------------------------------------------------------
>
>                 Key: YARN-3463
>                 URL: https://issues.apache.org/jira/browse/YARN-3463
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: capacityscheduler
>            Reporter: Craig Welch
>            Assignee: Craig Welch
>         Attachments: YARN-3463.50.patch, YARN-3643.58.patch
>
>
> Integrate the OrderingPolicy Framework with the CapacityScheduler



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to