[ 
https://issues.apache.org/jira/browse/YARN-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14504283#comment-14504283
 ] 

zhihai xu commented on YARN-3516:
---------------------------------

Hi [~xgong], Could you review the patch YARN-3516.000.patch? This is a very 
small change to fix a regression. thanks

> killing ContainerLocalizer action doesn't take effect when private localizer 
> receives FETCH_FAILURE status.
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-3516
>                 URL: https://issues.apache.org/jira/browse/YARN-3516
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>            Reporter: zhihai xu
>            Assignee: zhihai xu
>         Attachments: YARN-3516.000.patch
>
>
> killing ContainerLocalizer action doesn't take effect when private localizer 
> receives FETCH_FAILURE status. This is a typo from YARN-3024. With YARN-3024, 
> ContainerLocalizer will be killed only if {{action}} is set to 
> {{LocalizerAction.DIE}}, calling {{response.setLocalizerAction}} will be 
> overwritten. This is also a regression from old code.
> Also it make sense to kill the ContainerLocalizer when FETCH_FAILURE 
> happened, because the container will send CLEANUP_CONTAINER_RESOURCES event 
> after localization failure.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to