[
https://issues.apache.org/jira/browse/YARN-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14504513#comment-14504513
]
Hadoop QA commented on YARN-3516:
---------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12726776/YARN-3516.000.patch
against trunk revision d52de61.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.TestDataTransferProtocol
The following test timeouts occurred in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.TestLeaseRecovery2
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/7415//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7415//console
This message is automatically generated.
> killing ContainerLocalizer action doesn't take effect when private localizer
> receives FETCH_FAILURE status.
> -----------------------------------------------------------------------------------------------------------
>
> Key: YARN-3516
> URL: https://issues.apache.org/jira/browse/YARN-3516
> Project: Hadoop YARN
> Issue Type: Bug
> Components: nodemanager
> Reporter: zhihai xu
> Assignee: zhihai xu
> Attachments: YARN-3516.000.patch
>
>
> killing ContainerLocalizer action doesn't take effect when private localizer
> receives FETCH_FAILURE status. This is a typo from YARN-3024. With YARN-3024,
> ContainerLocalizer will be killed only if {{action}} is set to
> {{LocalizerAction.DIE}}, calling {{response.setLocalizerAction}} will be
> overwritten. This is also a regression from old code.
> Also it make sense to kill the ContainerLocalizer when FETCH_FAILURE
> happened, because the container will send CLEANUP_CONTAINER_RESOURCES event
> after localization failure.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
