[
https://issues.apache.org/jira/browse/YARN-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14506208#comment-14506208
]
Hadoop QA commented on YARN-3516:
---------------------------------
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 15m 1s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | javac | 7m 44s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 47s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 21s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 5m 34s | There were no new checkstyle
issues. |
| {color:green}+1{color} | install | 1m 34s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 32s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 1m 1s | The patch does not introduce
any new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | yarn tests | 5m 54s | Tests passed in
hadoop-yarn-server-nodemanager. |
| | | 47m 30s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12727051/YARN-3516.000.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / cfba355 |
| hadoop-yarn-server-nodemanager test log |
https://builds.apache.org/job/PreCommit-YARN-Build/7440/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-YARN-Build/7440/testReport/ |
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/7440//console |
This message was automatically generated.
> killing ContainerLocalizer action doesn't take effect when private localizer
> receives FETCH_FAILURE status.
> -----------------------------------------------------------------------------------------------------------
>
> Key: YARN-3516
> URL: https://issues.apache.org/jira/browse/YARN-3516
> Project: Hadoop YARN
> Issue Type: Bug
> Components: nodemanager
> Reporter: zhihai xu
> Assignee: zhihai xu
> Attachments: YARN-3516.000.patch
>
>
> killing ContainerLocalizer action doesn't take effect when private localizer
> receives FETCH_FAILURE status. This is a typo from YARN-3024. With YARN-3024,
> ContainerLocalizer will be killed only if {{action}} is set to
> {{LocalizerAction.DIE}}, calling {{response.setLocalizerAction}} will be
> overwritten. This is also a regression from old code.
> Also it make sense to kill the ContainerLocalizer when FETCH_FAILURE
> happened, because the container will send CLEANUP_CONTAINER_RESOURCES event
> after localization failure.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
