[ 
https://issues.apache.org/jira/browse/YARN-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14505286#comment-14505286
 ] 

Sangjin Lee commented on YARN-3046:
-----------------------------------

LGTM.

Just to close on one point, at a later point let's consider whether 
HierarchicalTimelineEntity makes more sense for the MR entities. If the 
parent-child navigation becomes more important (it's not clear if it will), 
then there seems to be a slight advantage with using 
HierarchicalTimelineEntity. If that turns out to be the case, we could 
conceivably create subclasses in a standard place for MR, and have all use 
cases use those concrete subclasses. But I'm fine deferring that aspect a 
little bit. It's not a critical point.

> [Event producers] Implement MapReduce AM writing MR events to v2 ATS
> --------------------------------------------------------------------
>
>                 Key: YARN-3046
>                 URL: https://issues.apache.org/jira/browse/YARN-3046
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Sangjin Lee
>            Assignee: Junping Du
>         Attachments: YARN-3046-no-test-v2.patch, YARN-3046-no-test.patch, 
> YARN-3046-v1-rebase.patch, YARN-3046-v1.patch, YARN-3046-v2.patch, 
> YARN-3046-v3.patch, YARN-3046-v4.patch, YARN-3046-v5.patch, YARN-3046-v6.patch
>
>
> Per design in YARN-2928, select a handful of MR metrics (e.g. HDFS bytes 
> written) and have the MR AM write the framework-specific metrics to ATS.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to