[ 
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14519906#comment-14519906
 ] 

Naganarasimha G R commented on YARN-3044:
-----------------------------------------

Thanks for the review [~djp] & [~sjlee0] lee],
bq. some of the issues reported by the jenkins build might be related to the 
patch?
Some might be but many(findbugs and testcase) are not related to this jira, 
hence planning to raise seperate jira to handle the same.
And some findbugs (like Unchecked/unconfirmed cast from 
org.apache.hadoop.yarn.server.resourcemanager.metrics.SystemMetricsEvent ) not 
planning to handle as its same as earlier code & if checks doesnt make sense 
here

bq. l.147: how about using a simple for loop?
Well AFAIK it only affects readability here and had taken entry set iterator 
here as its generally preferred in terms of performance and concurrency (not 
relevance here). If you feel readability is a issue then can modify to simple 
loop :)

bq. l.179: curious, we could add them to the entity as metrics, right?
bq. So having them as events means that they should/will not be aggregated 
(e.g. from app => flow). Is that the intent with these values (CPU and cores)? 
I'm not exactly clear what these values indicate.
Well initially even though i had the same thoughts as that of [~djp], but it 
might be required to be aggregated (e.g. from app => flow) as its current value 
also is aggregation of all containers. 

As mentioned earlier, planning to raise jira for the following :
# To enhance TestSystemMetricsPublisherForV2 to ensure that test case verifies 
the published entity is populated as desired (similar to ATSV1).
# To add interface in TimelineClient to push application specific 
configurations as all are not captured as part of RM

Please provide your opinion.
Had one query, as earlier suggested by [~djp], where to add the util 
class(Package and classname) which converts the SystemEntities to Timeline 
entities and vice versa?
Also shall i handle this as part of this patch or 
TestSystemMetricsPublisherForV2 enhancement patch ?

> [Event producers] Implement RM writing app lifecycle events to ATS
> ------------------------------------------------------------------
>
>                 Key: YARN-3044
>                 URL: https://issues.apache.org/jira/browse/YARN-3044
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Sangjin Lee
>            Assignee: Naganarasimha G R
>         Attachments: YARN-3044-YARN-2928.004.patch, 
> YARN-3044.20150325-1.patch, YARN-3044.20150406-1.patch, 
> YARN-3044.20150416-1.patch
>
>
> Per design in YARN-2928, implement RM writing app lifecycle events to ATS.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to