[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14520322#comment-14520322
]
Sangjin Lee commented on YARN-3044:
-----------------------------------
{quote}
Some might be but many(findbugs and testcase) are not related to this jira,
hence planning to raise seperate jira to handle the same.
And some findbugs (like Unchecked/unconfirmed cast from
org.apache.hadoop.yarn.server.resourcemanager.metrics.SystemMetricsEvent ) not
planning to handle as its same as earlier code & if checks doesnt make sense
here
{quote}
Understood. We should try to resolve the ones that make sense but don't have to
be pedantic. By the way, note that I filed a separate JIRA for the unit test
issues that already exist on YARN-2928 (YARN-3562).
{quote}
Well AFAIK it only affects readability here and had taken entry set iterator
here as its generally preferred in terms of performance and concurrency (not
relevance here). If you feel readability is a issue then can modify to simple
loop
{quote}
That's fine. It was a style nit (if that wasn't clear).
> [Event producers] Implement RM writing app lifecycle events to ATS
> ------------------------------------------------------------------
>
> Key: YARN-3044
> URL: https://issues.apache.org/jira/browse/YARN-3044
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Sangjin Lee
> Assignee: Naganarasimha G R
> Attachments: YARN-3044-YARN-2928.004.patch,
> YARN-3044.20150325-1.patch, YARN-3044.20150406-1.patch,
> YARN-3044.20150416-1.patch
>
>
> Per design in YARN-2928, implement RM writing app lifecycle events to ATS.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
