[
https://issues.apache.org/jira/browse/YARN-3565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14526629#comment-14526629
]
Naganarasimha G R commented on YARN-3565:
-----------------------------------------
Thanks for the review comments [~vinodkv]
Agree with most of your suggestions but had few queries overall,
* can there be changes again when labels as constraints are introduced ? As i
am not sure exclusivity will have any significance with constraints, if we plan
to make use of NodeLabel class for constraints too.
* CLI will also require changes for adding, removing cluster node labels and
mapping of nodes to labels ?
* If required to modify RMNodeLabelsManager.replaceLabelsOnNode() then i think
we need to make yarn-3521 dependent on this jira, right ?
> NodeHeartbeatRequest/RegisterNodeManagerRequest should use NodeLabel object
> instead of String
> ---------------------------------------------------------------------------------------------
>
> Key: YARN-3565
> URL: https://issues.apache.org/jira/browse/YARN-3565
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: api, client, resourcemanager
> Reporter: Wangda Tan
> Assignee: Naganarasimha G R
> Priority: Blocker
> Attachments: YARN-3565-20150502-1.patch
>
>
> Now NM HB/Register uses Set<String>, it will be hard to add new fields if we
> want to support specifying NodeLabel type such as exclusivity/constraints,
> etc. We need to make sure rolling upgrade works.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
