Wangda Tan commented on YARN-3583:

Hi [~sunilg],
Thanks for updating,

bq. In yarn_service_resourcemanager_service_protos, 
ReplaceLabelsOnNodeRequestProto still used NodeIdToLabelsProto. 
So I feel we can keep the same.
I think you can move NodeIdToLabelsProto to 
yarn_server_resourcemanager_service_protos, yarn_protos supposes to include 
only client-side-visible objects.

bq. I feel existing test case testGetNodeToLabelsResponsePBImpl which is 
present in TestPBImplRecords internally covers the verification for 
NodeIdToLabelsInfoProto. Pls suggest if otherwise.
I guess so, but I think it's better to add it separately to make sure it will 
be tested.

Took a quick look at TestClientRMService, have you checked 
NodeLabel.isExclusive after received from RM? I didn't find it..

> Support of NodeLabel object instead of plain String in YarnClient side.
> -----------------------------------------------------------------------
>                 Key: YARN-3583
>                 URL: https://issues.apache.org/jira/browse/YARN-3583
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: client
>    Affects Versions: 2.6.0
>            Reporter: Sunil G
>            Assignee: Sunil G
>         Attachments: 0001-YARN-3583.patch, 0002-YARN-3583.patch
> Similar to YARN-3521, use NodeLabel objects in YarnClient side apis.
> getLabelsToNodes/getNodeToLabels api's can use NodeLabel object instead of 
> using plain label name.
> This will help to bring other label details such as Exclusivity to client 
> side.

This message was sent by Atlassian JIRA

Reply via email to