[
https://issues.apache.org/jira/browse/YARN-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14548510#comment-14548510
]
Wangda Tan commented on YARN-3583:
----------------------------------
[~sunilg],
Thanks updating, mostly looks good, 2 nits:
yarn_server_resourcemanager_service_proto:
- NodeIdToLabelsProto -> NodeIdToLabelsNameProto, otherwise people will confuse
this with NodeIdToLabelsInfoProto
- A couple of asserts in tests like {{Assert.assertTrue(y.isExclusive() ==
true)}}, could be changed to {{Assert.assertTrue/False(y.isExclusive())}}
> Support of NodeLabel object instead of plain String in YarnClient side.
> -----------------------------------------------------------------------
>
> Key: YARN-3583
> URL: https://issues.apache.org/jira/browse/YARN-3583
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: client
> Affects Versions: 2.6.0
> Reporter: Sunil G
> Assignee: Sunil G
> Attachments: 0001-YARN-3583.patch, 0002-YARN-3583.patch,
> 0003-YARN-3583.patch
>
>
> Similar to YARN-3521, use NodeLabel objects in YarnClient side apis.
> getLabelsToNodes/getNodeToLabels api's can use NodeLabel object instead of
> using plain label name.
> This will help to bring other label details such as Exclusivity to client
> side.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
