Craig Welch commented on YARN-3632:

Just uploaded a patch which addresses the comments.  It holds off on reordering 
entities until just before iteration to avoid the unnecessary repeated 
reordering detailed above.

bq. this null check is not needed, if it can never be null;

It can be null if the asks are empty ( in which case, we don't want to queue 
for reordering, and don't :-) )

> Ordering policy should be allowed to reorder an application when demand 
> changes
> -------------------------------------------------------------------------------
>                 Key: YARN-3632
>                 URL: https://issues.apache.org/jira/browse/YARN-3632
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: capacityscheduler
>            Reporter: Craig Welch
>            Assignee: Craig Welch
>         Attachments: YARN-3632.0.patch, YARN-3632.1.patch, YARN-3632.3.patch, 
> YARN-3632.4.patch, YARN-3632.5.patch, YARN-3632.6.patch
> At present, ordering policies have the option to have an application 
> re-ordered (for allocation and preemption) when it is allocated to or a 
> container is recovered from the application.  Some ordering policies may also 
> need to reorder when demand changes if that is part of the ordering 
> comparison, this needs to be made available (and used by the 
> fairorderingpolicy when sizebasedweight is true)

This message was sent by Atlassian JIRA

Reply via email to