[ 
https://issues.apache.org/jira/browse/YARN-3632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14556814#comment-14556814
 ] 

Craig Welch commented on YARN-3632:
-----------------------------------

bq. {code} if (application.updateResourceRequests(ask)) { } {code}

No, I want to avoid any possible interleaving of locks between the application 
and the queue, getting the ordering policy locks the queue briefly and this 
should not happen inside an application lock.

bq. {code} updateDemandForQueue {code}

The demand is being updated for that queue, I think the naming is clear enough.



> Ordering policy should be allowed to reorder an application when demand 
> changes
> -------------------------------------------------------------------------------
>
>                 Key: YARN-3632
>                 URL: https://issues.apache.org/jira/browse/YARN-3632
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: capacityscheduler
>            Reporter: Craig Welch
>            Assignee: Craig Welch
>         Attachments: YARN-3632.0.patch, YARN-3632.1.patch, YARN-3632.3.patch, 
> YARN-3632.4.patch, YARN-3632.5.patch, YARN-3632.6.patch, YARN-3632.7.patch
>
>
> At present, ordering policies have the option to have an application 
> re-ordered (for allocation and preemption) when it is allocated to or a 
> container is recovered from the application.  Some ordering policies may also 
> need to reorder when demand changes if that is part of the ordering 
> comparison, this needs to be made available (and used by the 
> fairorderingpolicy when sizebasedweight is true)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to