[ 
https://issues.apache.org/jira/browse/YARN-3792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14588441#comment-14588441
 ] 

Sangjin Lee commented on YARN-3792:
-----------------------------------

{quote}
Other approach i can think of is to make the test sleep for 500 seconds 3~4 
times or till the desired result is got (i think this is the approach which is 
followed in most of the test cases which are highly async), thoughts ?
{quote}

Given the asynchronous nature (and lack of strong coordination between 
actions), I'm +1 on looping a few times.

{quote}
Well atleast in my environment(latest ubuntu) even after JAVA_HOME was set 
properly in shell, test cases when executed from eclipse were failing because 
of the JAVA_HOME was not availble and it took a while for me to figure out 
doing this. Hence i thought it would be usefull information for others who r 
testing for the first time, If you guys feel not necessary i can remove it.
{quote}

IMO the comment seems a little out of place. I would prefer not having this 
comment here, but I'd like to hear what others think.

{quote}
yes its req, as mentioned earlier for 
TestDistributedShellWithNodeLabels.testDSShellWithNodeLabelExpression was 
failing because method name rule will not set be set in 
TestDistributedShell.setupInternal
{quote}

Thanks for reminding me. I didn't realize that 
{{TestDistributedShellWithNodeLabels}} does *NOT* extend 
{{TestDistributedShell}}. I'm not sure why that is the case. Maybe they didn't 
want to run the base tests? Unless that changes, I guess we'll have to check 
for null. This looks pretty brittle however. Sigh.

> Test case failures in TestDistributedShell and some issue fixes related to 
> ATSV2
> --------------------------------------------------------------------------------
>
>                 Key: YARN-3792
>                 URL: https://issues.apache.org/jira/browse/YARN-3792
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Naganarasimha G R
>            Assignee: Naganarasimha G R
>         Attachments: YARN-3792-YARN-2928.001.patch
>
>
> # encountered [testcase 
> failures|https://builds.apache.org/job/PreCommit-YARN-Build/8233/testReport/] 
> which was happening even without the patch modifications in YARN-3044
> TestDistributedShell.testDSShellWithoutDomainV2CustomizedFlow
> TestDistributedShell.testDSShellWithoutDomainV2DefaultFlow
> TestDistributedShellWithNodeLabels.testDSShellWithNodeLabelExpression
> # Remove unused {{enableATSV1}} in testDisstributedShell
> # container metrics needs to be published only for v2 test cases of 
> testDisstributedShell
> # Nullpointer was thrown in TimelineClientImpl.constructResURI when Aux 
> service was not configured and {{TimelineClient.putObjects}} was getting 
> invoked.
> # Race condition for the Application events to published and test case 
> verification for RM's ApplicationFinished Timeline Events
> # Application Tags for converted to lowercase in 
> ApplicationSubmissionContextPBimpl, hence RMTimelinecollector was not able to 
> detect to custom flow details of the app



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to