[ 
https://issues.apache.org/jira/browse/YARN-3792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14596730#comment-14596730
 ] 

Sangjin Lee commented on YARN-3792:
-----------------------------------

Thanks [~Naganarasimha] for the update!

+1 on the test failure. It appears to be an issue unrelated to the timeline 
service.

It does seem like the whitespace is related to the patch (or in the vicinity of 
the patch). Could you kindly do a quick change to remove those extra spaces?

Also, for findbugs, I ran findbugs against those two projects (distributed 
shell and resource manager). I do see several findbugs warnings, and they are 
not introduced by this patch but do appear to be related to the YARN-2928 work.

distributed shell:
{code}
<file 
classname='org.apache.hadoop.yarn.applications.distributedshell.Client'><BugInstance
 type='DM_BOXED_PRIMITIVE_FOR_PARSING' priority='High' category='PERFORMANCE' 
message='Boxing/unboxing to parse a primitive 
org.apache.hadoop.yarn.applications.distributedshell.Client.init(String[])' 
lineNumber='466'/></file>
{code}

resource manager:
{code}
<file 
classname='org.apache.hadoop.yarn.server.resourcemanager.metrics.AbstractTimelineServicePublisher'><BugInstance
 type='BC_UNCONFIRMED_CAST' priority='Normal' category='STYLE' 
message='Unchecked/unconfirmed cast from 
org.apache.hadoop.yarn.server.resourcemanager.metrics.SystemMetricsEvent to 
org.apache.hadoop.yarn.server.resourcemanager.metrics.AppAttemptFinishedEvent 
in 
org.apache.hadoop.yarn.server.resourcemanager.metrics.AbstractTimelineServicePublisher.handle(SystemMetricsEvent)'
 lineNumber='79'/><BugInstance type='BC_UNCONFIRMED_CAST' priority='Normal' 
category='STYLE' message='Unchecked/unconfirmed cast from 
org.apache.hadoop.yarn.server.resourcemanager.metrics.SystemMetricsEvent to 
org.apache.hadoop.yarn.server.resourcemanager.metrics.AppAttemptRegisteredEvent 
in 
org.apache.hadoop.yarn.server.resourcemanager.metrics.AbstractTimelineServicePublisher.handle(SystemMetricsEvent)'
 lineNumber='76'/><BugInstance type='BC_UNCONFIRMED_CAST' priority='Normal' 
category='STYLE' message='Unchecked/unconfirmed cast from 
org.apache.hadoop.yarn.server.resourcemanager.metrics.SystemMetricsEvent to 
org.apache.hadoop.yarn.server.resourcemanager.metrics.ApplicationACLsUpdatedEvent
 in 
org.apache.hadoop.yarn.server.resourcemanager.metrics.AbstractTimelineServicePublisher.handle(SystemMetricsEvent)'
 lineNumber='73'/><BugInstance type='BC_UNCONFIRMED_CAST' priority='Normal' 
category='STYLE' message='Unchecked/unconfirmed cast from 
org.apache.hadoop.yarn.server.resourcemanager.metrics.SystemMetricsEvent to 
org.apache.hadoop.yarn.server.resourcemanager.metrics.ApplicationCreatedEvent 
in 
org.apache.hadoop.yarn.server.resourcemanager.metrics.AbstractTimelineServicePublisher.handle(SystemMetricsEvent)'
 lineNumber='67'/><BugInstance type='BC_UNCONFIRMED_CAST' priority='Normal' 
category='STYLE' message='Unchecked/unconfirmed cast from 
org.apache.hadoop.yarn.server.resourcemanager.metrics.SystemMetricsEvent to 
org.apache.hadoop.yarn.server.resourcemanager.metrics.ApplicationFinishedEvent 
in 
org.apache.hadoop.yarn.server.resourcemanager.metrics.AbstractTimelineServicePublisher.handle(SystemMetricsEvent)'
 lineNumber='70'/><BugInstance type='BC_UNCONFIRMED_CAST' priority='Normal' 
category='STYLE' message='Unchecked/unconfirmed cast from 
org.apache.hadoop.yarn.server.resourcemanager.metrics.SystemMetricsEvent to 
org.apache.hadoop.yarn.server.resourcemanager.metrics.ContainerCreatedEvent in 
org.apache.hadoop.yarn.server.resourcemanager.metrics.AbstractTimelineServicePublisher.handle(SystemMetricsEvent)'
 lineNumber='82'/><BugInstance type='BC_UNCONFIRMED_CAST' priority='Normal' 
category='STYLE' message='Unchecked/unconfirmed cast from 
org.apache.hadoop.yarn.server.resourcemanager.metrics.SystemMetricsEvent to 
org.apache.hadoop.yarn.server.resourcemanager.metrics.ContainerFinishedEvent in 
org.apache.hadoop.yarn.server.resourcemanager.metrics.AbstractTimelineServicePublisher.handle(SystemMetricsEvent)'
 lineNumber='85'/></file>{code}

It would be nice to address them (at least the one on Client.java) here, but if 
you're not inclined, we could do it later... Let me know how you want to 
proceed.

> Test case failures in TestDistributedShell and some issue fixes related to 
> ATSV2
> --------------------------------------------------------------------------------
>
>                 Key: YARN-3792
>                 URL: https://issues.apache.org/jira/browse/YARN-3792
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Naganarasimha G R
>            Assignee: Naganarasimha G R
>         Attachments: YARN-3792-YARN-2928.001.patch, 
> YARN-3792-YARN-2928.002.patch, YARN-3792-YARN-2928.003.patch
>
>
> # encountered [testcase 
> failures|https://builds.apache.org/job/PreCommit-YARN-Build/8233/testReport/] 
> which was happening even without the patch modifications in YARN-3044
> TestDistributedShell.testDSShellWithoutDomainV2CustomizedFlow
> TestDistributedShell.testDSShellWithoutDomainV2DefaultFlow
> TestDistributedShellWithNodeLabels.testDSShellWithNodeLabelExpression
> # Remove unused {{enableATSV1}} in testDisstributedShell
> # container metrics needs to be published only for v2 test cases of 
> testDisstributedShell
> # Nullpointer was thrown in TimelineClientImpl.constructResURI when Aux 
> service was not configured and {{TimelineClient.putObjects}} was getting 
> invoked.
> # Race condition for the Application events to published and test case 
> verification for RM's ApplicationFinished Timeline Events
> # Application Tags for converted to lowercase in 
> ApplicationSubmissionContextPBimpl, hence RMTimelinecollector was not able to 
> detect to custom flow details of the app



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to