[
https://issues.apache.org/jira/browse/YARN-3792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14594025#comment-14594025
]
Sangjin Lee commented on YARN-3792:
-----------------------------------
I tested the latest patch, and at least on my local environment all the unit
tests seem to pass.
It looks good to me overall. I have a couple of small nits. It'd be great if
you could take a look at them and address them quickly.
(TestDistributedShellWithNodeLabels.java)
- l. 47: spacing
(TimelineClientImpl.java)
- l.385: let's use a more standard java style condition: i.e.
{{timelineServiceAddress == null}}
We'll also need to see the jenkins result (looks like there is a large queue so
it might take a while).
> Test case failures in TestDistributedShell and some issue fixes related to
> ATSV2
> --------------------------------------------------------------------------------
>
> Key: YARN-3792
> URL: https://issues.apache.org/jira/browse/YARN-3792
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Naganarasimha G R
> Assignee: Naganarasimha G R
> Attachments: YARN-3792-YARN-2928.001.patch,
> YARN-3792-YARN-2928.002.patch
>
>
> # encountered [testcase
> failures|https://builds.apache.org/job/PreCommit-YARN-Build/8233/testReport/]
> which was happening even without the patch modifications in YARN-3044
> TestDistributedShell.testDSShellWithoutDomainV2CustomizedFlow
> TestDistributedShell.testDSShellWithoutDomainV2DefaultFlow
> TestDistributedShellWithNodeLabels.testDSShellWithNodeLabelExpression
> # Remove unused {{enableATSV1}} in testDisstributedShell
> # container metrics needs to be published only for v2 test cases of
> testDisstributedShell
> # Nullpointer was thrown in TimelineClientImpl.constructResURI when Aux
> service was not configured and {{TimelineClient.putObjects}} was getting
> invoked.
> # Race condition for the Application events to published and test case
> verification for RM's ApplicationFinished Timeline Events
> # Application Tags for converted to lowercase in
> ApplicationSubmissionContextPBimpl, hence RMTimelinecollector was not able to
> detect to custom flow details of the app
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
