[ 
https://issues.apache.org/jira/browse/YARN-3885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14619989#comment-14619989
 ] 

Ajith S commented on YARN-3885:
-------------------------------

          /root
                A
            /\
                C B
                  /\
                  D E


+*Before fix:*+
NAME: queueA CUR: <memory:209, vCores:0> PEN: <memory:0, vCores:0> GAR: 
<memory:200, vCores:0> NORM: NaN IDEAL_ASSIGNED: <memory:209, vCores:0> 
IDEAL_PREEMPT: <memory:0, vCores:0> ACTUAL_PREEMPT: <memory:0, vCores:0> 
*{color:red}UNTOUCHABLE: <memory:9, vCores:0> PREEMPTABLE: <memory:0, 
vCores:0>{color}*
NAME: queueB CUR: <memory:60, vCores:0> PEN: <memory:0, vCores:0> GAR: 
<memory:60, vCores:0> NORM: NaN IDEAL_ASSIGNED: <memory:60, vCores:0> 
IDEAL_PREEMPT: <memory:0, vCores:0> ACTUAL_PREEMPT: <memory:0, vCores:0> 
*UNTOUCHABLE: <memory:0, vCores:0> PREEMPTABLE: <memory:0, vCores:0>*
NAME: queueC CUR: <memory:150, vCores:0> PEN: <memory:0, vCores:0> GAR: 
<memory:139, vCores:0> NORM: 1.0 IDEAL_ASSIGNED: <memory:149, vCores:1> 
IDEAL_PREEMPT: <memory:1, vCores:-1> ACTUAL_PREEMPT: <memory:0, vCores:0> 
*UNTOUCHABLE: <memory:1, vCores:0> PREEMPTABLE: <memory:0, vCores:0>*
NAME: queueD CUR: <memory:100, vCores:0> PEN: <memory:0, vCores:0> GAR: 
<memory:100, vCores:0> NORM: NaN IDEAL_ASSIGNED: <memory:100, vCores:0> 
IDEAL_PREEMPT: <memory:0, vCores:0> ACTUAL_PREEMPT: <memory:0, vCores:0> 
*UNTOUCHABLE: <memory:0, vCores:0> PREEMPTABLE: <memory:0, vCores:0>*
NAME: queueE CUR: <memory:50, vCores:0> PEN: <memory:0, vCores:0> GAR: 
<memory:40, vCores:0> NORM: 1.0 IDEAL_ASSIGNED: <memory:49, vCores:1> 
IDEAL_PREEMPT: <memory:1, vCores:-1> ACTUAL_PREEMPT: <memory:0, vCores:0> 
*UNTOUCHABLE: <memory:0, vCores:0> PREEMPTABLE: <memory:10, vCores:0>*

+*After:*+
NAME: queueA CUR: <memory:209, vCores:0> PEN: <memory:0, vCores:0> GAR: 
<memory:200, vCores:0> NORM: 1.0 IDEAL_ASSIGNED: <memory:201, vCores:1> 
IDEAL_PREEMPT: <memory:8, vCores:-1> ACTUAL_PREEMPT: <memory:0, vCores:0> 
*{color:green}UNTOUCHABLE: <memory:0, vCores:0> PREEMPTABLE: <memory:10, 
vCores:0>{color}*
NAME: queueB CUR: <memory:60, vCores:0> PEN: <memory:0, vCores:0> GAR: 
<memory:60, vCores:0> NORM: NaN IDEAL_ASSIGNED: <memory:60, vCores:0> 
IDEAL_PREEMPT: <memory:0, vCores:0> ACTUAL_PREEMPT: <memory:0, vCores:0> 
*UNTOUCHABLE: <memory:0, vCores:0> PREEMPTABLE: <memory:0, vCores:0>*
NAME: queueC CUR: <memory:150, vCores:0> PEN: <memory:0, vCores:0> GAR: 
<memory:139, vCores:0> NORM: 1.0 IDEAL_ASSIGNED: <memory:141, vCores:1> 
IDEAL_PREEMPT: <memory:9, vCores:-1> ACTUAL_PREEMPT: <memory:0, vCores:0> 
*UNTOUCHABLE: <memory:1, vCores:0> PREEMPTABLE: <memory:10, vCores:0>*
NAME: queueD CUR: <memory:100, vCores:0> PEN: <memory:0, vCores:0> GAR: 
<memory:100, vCores:0> NORM: NaN IDEAL_ASSIGNED: <memory:100, vCores:0> 
IDEAL_PREEMPT: <memory:0, vCores:0> ACTUAL_PREEMPT: <memory:0, vCores:0> 
*UNTOUCHABLE: <memory:0, vCores:0> PREEMPTABLE: <memory:0, vCores:0>*
NAME: queueE CUR: <memory:50, vCores:0> PEN: <memory:0, vCores:0> GAR: 
<memory:40, vCores:0> NORM: 1.0 IDEAL_ASSIGNED: <memory:41, vCores:1> 
IDEAL_PREEMPT: <memory:9, vCores:-1> ACTUAL_PREEMPT: <memory:0, vCores:0> 
*UNTOUCHABLE: <memory:0, vCores:0> PREEMPTABLE: <memory:10, vCores:0>*

> ProportionalCapacityPreemptionPolicy doesn't preempt if queue is more than 2 
> level
> ----------------------------------------------------------------------------------
>
>                 Key: YARN-3885
>                 URL: https://issues.apache.org/jira/browse/YARN-3885
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: yarn
>    Affects Versions: 2.8.0
>            Reporter: Ajith S
>            Priority: Critical
>         Attachments: YARN-3885.02.patch, YARN-3885.03.patch, 
> YARN-3885.04.patch, YARN-3885.patch
>
>
> when preemption policy is {{ProportionalCapacityPreemptionPolicy.cloneQueues}}
> this piece of code, to calculate {{untoucable}} doesnt consider al the 
> children, it considers only immediate childern



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to