[
https://issues.apache.org/jira/browse/YARN-3885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14625302#comment-14625302
]
Wangda Tan commented on YARN-3885:
----------------------------------
Increase to blocker since this is a bad bug.
Thanks for working on this [~ajithshetty].
I think patch looks generally good except one thing also mentioned by
[~xinxianyin]:
bq. for non-leaf queues, min(sum of children's PREEMOTABLEs, extra) -----(this
is what CHILDRENPREEMPTABLE does in the patch)
Specifying {{ret.preemptableExtra = childrensPreemptable;}} seems not enough.
Could you add a test to verify: when sum(queue.children.preemptable) > extra,
we can still get correct preemption result?
> ProportionalCapacityPreemptionPolicy doesn't preempt if queue is more than 2
> level
> ----------------------------------------------------------------------------------
>
> Key: YARN-3885
> URL: https://issues.apache.org/jira/browse/YARN-3885
> Project: Hadoop YARN
> Issue Type: Bug
> Components: yarn
> Affects Versions: 2.8.0
> Reporter: Ajith S
> Assignee: Ajith S
> Priority: Blocker
> Attachments: YARN-3885.02.patch, YARN-3885.03.patch,
> YARN-3885.04.patch, YARN-3885.patch
>
>
> when preemption policy is {{ProportionalCapacityPreemptionPolicy.cloneQueues}}
> this piece of code, to calculate {{untoucable}} doesnt consider al the
> children, it considers only immediate childern
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
