[ https://issues.apache.org/jira/browse/YARN-3885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14626186#comment-14626186 ]
Ajith S commented on YARN-3885: ------------------------------- Hi [~leftnoteasy], thanks for the input The testcase i have added, has the same scenario, as you can see form the log snippet, the QueueA has 9 extra(209-200) which is less than sum(queue.children.preemptable) is 10. But the check {code} if (Resources.greaterThanOrEqual( rc, partitionResource, childrensPreemptable, extra)) { ret.untouchableExtra = Resource.newInstance(0, 0); {code} makes the queueA untouchable=0, therefore resulting in correct preemption Please correct me if i am wrong > ProportionalCapacityPreemptionPolicy doesn't preempt if queue is more than 2 > level > ---------------------------------------------------------------------------------- > > Key: YARN-3885 > URL: https://issues.apache.org/jira/browse/YARN-3885 > Project: Hadoop YARN > Issue Type: Bug > Components: yarn > Affects Versions: 2.8.0 > Reporter: Ajith S > Assignee: Ajith S > Priority: Blocker > Attachments: YARN-3885.02.patch, YARN-3885.03.patch, > YARN-3885.04.patch, YARN-3885.patch > > > when preemption policy is {{ProportionalCapacityPreemptionPolicy.cloneQueues}} > this piece of code, to calculate {{untoucable}} doesnt consider al the > children, it considers only immediate childern -- This message was sent by Atlassian JIRA (v6.3.4#6332)