[
https://issues.apache.org/jira/browse/YARN-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14662672#comment-14662672
]
Li Lu commented on YARN-3814:
-----------------------------
Thanks [~varun_saxena] for working on this JIRA! I looked at the latest patch
and the reference patch, and here are some of my comments (I may post something
new later).
# With regard to the endpoint, I'm not quite familiar with the background, but
is there a strong reason for us to _not_ to distinguish entity and entities? I
think it is helpful if the user can clearly expect whether it's a single entity
or a set of entities to be returned from a call (even if the set may contain 0
or 1 entities)? Also, it looks a little bit awkward to return a set of entities
if we use an endpoint called "entity" (and vice versa).
# Since we already have aggregation related designs in the reference patch, I
suggest we include it in the final version of this patch. Although we may add
more details to this call in the future, I believe it will be quite helpful to
include the code skeleton.
# {{private static EnumSet<Field> parseFieldsStr(String str, String
delimiter)}}, are there any special reasons we cannot adopt the way in the
reference patch to parse the enum set?
# {{FileSystemTimelineReaderImpl}}, why we need to swallow
FileNotFoundExceptions? Given this implementation is mainly for unit tests I
think we need to be extremely cautious on dealing with these exceptions. A
FileNotFoundException may indicate we have some problems in other parts of our
code.
> REST API implementation for getting raw entities in TimelineReader
> ------------------------------------------------------------------
>
> Key: YARN-3814
> URL: https://issues.apache.org/jira/browse/YARN-3814
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Affects Versions: YARN-2928
> Reporter: Varun Saxena
> Assignee: Varun Saxena
> Attachments: YARN-3814-YARN-2928.01.patch,
> YARN-3814-YARN-2928.02.patch, YARN-3814-YARN-2928.03.patch,
> YARN-3814.reference.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
