[ https://issues.apache.org/jira/browse/YARN-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14634497#comment-14634497 ]
Hadoop QA commented on YARN-3026: --------------------------------- \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | pre-patch | 16m 24s | Pre-patch trunk compilation is healthy. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:green}+1{color} | tests included | 0m 0s | The patch appears to include 5 new or modified test files. | | {color:green}+1{color} | javac | 7m 46s | There were no new javac warning messages. | | {color:green}+1{color} | javadoc | 9m 36s | There were no new javadoc warning messages. | | {color:green}+1{color} | release audit | 0m 24s | The applied patch does not increase the total number of release audit warnings. | | {color:red}-1{color} | checkstyle | 0m 48s | The applied patch generated 37 new checkstyle issues (total was 394, now 357). | | {color:red}-1{color} | whitespace | 1m 20s | The patch has 6 line(s) that end in whitespace. Use git apply --whitespace=fix. | | {color:green}+1{color} | install | 1m 25s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 34s | The patch built with eclipse:eclipse. | | {color:green}+1{color} | findbugs | 1m 25s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. | | {color:red}-1{color} | yarn tests | 61m 44s | Tests failed in hadoop-yarn-server-resourcemanager. | | | | 101m 31s | | \\ \\ || Reason || Tests || | Timed out tests | org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestNodeLabelContainerAllocation | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12746226/YARN-3026.3.patch | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | trunk / 773c670 | | checkstyle | https://builds.apache.org/job/PreCommit-YARN-Build/8591/artifact/patchprocess/diffcheckstylehadoop-yarn-server-resourcemanager.txt | | whitespace | https://builds.apache.org/job/PreCommit-YARN-Build/8591/artifact/patchprocess/whitespace.txt | | hadoop-yarn-server-resourcemanager test log | https://builds.apache.org/job/PreCommit-YARN-Build/8591/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt | | Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/8591/testReport/ | | Java | 1.7.0_55 | | uname | Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Console output | https://builds.apache.org/job/PreCommit-YARN-Build/8591/console | This message was automatically generated. > Move application-specific container allocation logic from LeafQueue to > FiCaSchedulerApp > --------------------------------------------------------------------------------------- > > Key: YARN-3026 > URL: https://issues.apache.org/jira/browse/YARN-3026 > Project: Hadoop YARN > Issue Type: Task > Components: capacityscheduler > Reporter: Wangda Tan > Assignee: Wangda Tan > Attachments: YARN-3026.1.patch, YARN-3026.2.patch, YARN-3026.3.patch > > > Have a discussion with [~vinodkv] and [~jianhe]: > In existing Capacity Scheduler, all allocation logics of and under LeafQueue > are located in LeafQueue.java in implementation. To make a cleaner scope of > LeafQueue, we'd better move some of them to FiCaSchedulerApp. > Ideal scope of LeafQueue should be: when a LeafQueue receives some resources > from ParentQueue (like 15% of cluster resource), and it distributes resources > to children apps, and it should be agnostic to internal logic of children > apps (like delayed-scheduling, etc.). IAW, LeafQueue shouldn't decide how > application allocating container from given resources. -- This message was sent by Atlassian JIRA (v6.3.4#6332)