[ 
https://issues.apache.org/jira/browse/YARN-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14640882#comment-14640882
 ] 

Jian He commented on YARN-3026:
-------------------------------

- this could be simplified a bit  
{code}
      List<CSQueue> childrenList = new ArrayList<>(childQueues);
        Collections.sort(childrenList, nonPartitionedQueueComparator);
        childQueues.clear();
        childQueues.addAll(childrenList);
{code}
- testExcessReservationWillBeUnreserved - some comments do not match code, 
could you fix that too.

> Move application-specific container allocation logic from LeafQueue to 
> FiCaSchedulerApp
> ---------------------------------------------------------------------------------------
>
>                 Key: YARN-3026
>                 URL: https://issues.apache.org/jira/browse/YARN-3026
>             Project: Hadoop YARN
>          Issue Type: Task
>          Components: capacityscheduler
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
>         Attachments: YARN-3026.1.patch, YARN-3026.2.patch, YARN-3026.3.patch, 
> YARN-3026.4.patch, YARN-3026.5.patch
>
>
> Have a discussion with [~vinodkv] and [~jianhe]: 
> In existing Capacity Scheduler, all allocation logics of and under LeafQueue 
> are located in LeafQueue.java in implementation. To make a cleaner scope of 
> LeafQueue, we'd better move some of them to FiCaSchedulerApp.
> Ideal scope of LeafQueue should be: when a LeafQueue receives some resources 
> from ParentQueue (like 15% of cluster resource), and it distributes resources 
> to children apps, and it should be agnostic to internal logic of children 
> apps (like delayed-scheduling, etc.). IAW, LeafQueue shouldn't decide how 
> application allocating container from given resources.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to