[ 
https://issues.apache.org/jira/browse/YARN-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14637776#comment-14637776
 ] 

Jian He commented on YARN-3026:
-------------------------------

Haven't looked all, few comments so far.
- remove below logs as they kind dup with following logs
{code}
if (LOG.isDebugEnabled()) {
  LOG.debug("post-assignContainers for application 
"
      + application.getApplicationId());
}
if (LOG.isDebugEnabled()) {
  LOG.debug("pre-assignContainers for application "

      + getApplicationId());
  showRequests();
} {code}
- Below shouldn’t return NULL_ASSIGNMENT ?
{code}
if (schedulingMode == SchedulingMode.IGNORE_PARTITION_EXCLUSIVITY) {
    return 
NULL_ASSIGNMENT;
  }
}
{code}
{code}
} else {
  // Do not assign out of order w.r.t priorities
  return 
NULL_ASSIGNMENT;
}

{code}

> Move application-specific container allocation logic from LeafQueue to 
> FiCaSchedulerApp
> ---------------------------------------------------------------------------------------
>
>                 Key: YARN-3026
>                 URL: https://issues.apache.org/jira/browse/YARN-3026
>             Project: Hadoop YARN
>          Issue Type: Task
>          Components: capacityscheduler
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
>         Attachments: YARN-3026.1.patch, YARN-3026.2.patch, YARN-3026.3.patch
>
>
> Have a discussion with [~vinodkv] and [~jianhe]: 
> In existing Capacity Scheduler, all allocation logics of and under LeafQueue 
> are located in LeafQueue.java in implementation. To make a cleaner scope of 
> LeafQueue, we'd better move some of them to FiCaSchedulerApp.
> Ideal scope of LeafQueue should be: when a LeafQueue receives some resources 
> from ParentQueue (like 15% of cluster resource), and it distributes resources 
> to children apps, and it should be agnostic to internal logic of children 
> apps (like delayed-scheduling, etc.). IAW, LeafQueue shouldn't decide how 
> application allocating container from given resources.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to