[
https://issues.apache.org/jira/browse/YARN-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14641343#comment-14641343
]
Anubhav Dhoot commented on YARN-3974:
-------------------------------------
Thanks Subru for improving these test cases.
I think we can make it derive from ParameterizedSchedulerTestBase and get rid
of ParameterizedReservationSystemTestBase
(Attaching patch that does this)
Some minor feedback
Casing for getreservationQueueName -> getReservationQueueName
Looks like there are some methods that are no longer called such as
validateNewReservationQueue which can be removed, which is great
> Refactor the reservation system test cases to use parameterized base test
> -------------------------------------------------------------------------
>
> Key: YARN-3974
> URL: https://issues.apache.org/jira/browse/YARN-3974
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: capacityscheduler, fairscheduler
> Reporter: Subru Krishnan
> Assignee: Subru Krishnan
> Attachments: YARN-3974-v1.patch
>
>
> We have two test suites for testing ReservationSystem against Capacity & Fair
> scheduler. We should combine them using a parametrized reservation system
> base test similar to YARN-2797
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
