[ https://issues.apache.org/jira/browse/YARN-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14643816#comment-14643816 ]
Hadoop QA commented on YARN-3974: --------------------------------- \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | pre-patch | 16m 22s | Pre-patch trunk compilation is healthy. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:green}+1{color} | tests included | 0m 0s | The patch appears to include 6 new or modified test files. | | {color:green}+1{color} | javac | 7m 48s | There were no new javac warning messages. | | {color:green}+1{color} | javadoc | 9m 44s | There were no new javadoc warning messages. | | {color:green}+1{color} | release audit | 0m 23s | The applied patch does not increase the total number of release audit warnings. | | {color:red}-1{color} | checkstyle | 0m 48s | The applied patch generated 1 new checkstyle issues (total was 45, now 37). | | {color:green}+1{color} | whitespace | 0m 2s | The patch has no lines that end in whitespace. | | {color:green}+1{color} | install | 1m 22s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with eclipse:eclipse. | | {color:green}+1{color} | findbugs | 1m 25s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. | | {color:green}+1{color} | yarn tests | 52m 25s | Tests passed in hadoop-yarn-server-resourcemanager. | | | | 90m 57s | | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12747483/YARN-3974-v3.patch | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | trunk / 3572ebd | | checkstyle | https://builds.apache.org/job/PreCommit-YARN-Build/8690/artifact/patchprocess/diffcheckstylehadoop-yarn-server-resourcemanager.txt | | hadoop-yarn-server-resourcemanager test log | https://builds.apache.org/job/PreCommit-YARN-Build/8690/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt | | Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/8690/testReport/ | | Java | 1.7.0_55 | | uname | Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Console output | https://builds.apache.org/job/PreCommit-YARN-Build/8690/console | This message was automatically generated. > Refactor the reservation system test cases to use parameterized base test > ------------------------------------------------------------------------- > > Key: YARN-3974 > URL: https://issues.apache.org/jira/browse/YARN-3974 > Project: Hadoop YARN > Issue Type: Sub-task > Components: capacityscheduler, fairscheduler > Reporter: Subru Krishnan > Assignee: Subru Krishnan > Attachments: YARN-3974-v1.patch, YARN-3974-v2.patch, > YARN-3974-v3.patch > > > We have two test suites for testing ReservationSystem against Capacity & Fair > scheduler. We should combine them using a parametrized reservation system > base test similar to YARN-2797 -- This message was sent by Atlassian JIRA (v6.3.4#6332)