[ https://issues.apache.org/jira/browse/YARN-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14645310#comment-14645310 ]
Anubhav Dhoot commented on YARN-3974: ------------------------------------- Hi Subru the patch looks mostly good. Minor comments. Why the change from link to code? Also there is a checkstyle error. > Refactor the reservation system test cases to use parameterized base test > ------------------------------------------------------------------------- > > Key: YARN-3974 > URL: https://issues.apache.org/jira/browse/YARN-3974 > Project: Hadoop YARN > Issue Type: Sub-task > Components: capacityscheduler, fairscheduler > Reporter: Subru Krishnan > Assignee: Subru Krishnan > Attachments: YARN-3974-v1.patch, YARN-3974-v2.patch, > YARN-3974-v3.patch > > > We have two test suites for testing ReservationSystem against Capacity & Fair > scheduler. We should combine them using a parametrized reservation system > base test similar to YARN-2797 -- This message was sent by Atlassian JIRA (v6.3.4#6332)