Jian He commented on YARN-3887:

thanks Sunil !  some comments on the patch:
- Do you plan to do client side changes as part of this jira ?
- RMAppUpdatePriorityEvent - RMApp may receive this event at many other states 
other than RUNNING state. In that case, the state-machine will throw 
InvalidEventException. I think we do not need to send event to RMApp, all it 
does is just get the application submission context and set the priority. This 
can be done at clientRMService. Similarly, the event to state-store can be sent 
directly from clientRMService.
- CapacityScheuduler#updateApplicationPriority does not need to be synchronized 

> Support for changing Application priority during runtime
> --------------------------------------------------------
>                 Key: YARN-3887
>                 URL: https://issues.apache.org/jira/browse/YARN-3887
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: capacityscheduler, resourcemanager
>            Reporter: Sunil G
>            Assignee: Sunil G
>         Attachments: 0001-YARN-3887.patch
> After YARN-2003, adding support to change priority of an application after 
> submission. This ticket will handle the server side implementation for same.
> A new RMAppEvent will be created to handle this, and will be common for all 
> schedulers.

This message was sent by Atlassian JIRA

Reply via email to