[
https://issues.apache.org/jira/browse/YARN-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14660952#comment-14660952
]
Zhijie Shen commented on YARN-3049:
-----------------------------------
As the issue is not blocking the whole reader implementation, how about letting
this patch in first? [~sjlee0]?
Some more comments about the issue:
1. ColumnHelper needs to be updated as well to return a byte[] column name
instead of a String one.
2. I'm worried that Bytes.toString() doesn't make the long integer be stored as
the way we want. If it isn't stored as the 8 bytes, we may not guarantee the
order of event columns.
3. FlowRunId in the row key should be fine, because the row key is never
converted to String again. But it's good to double check.
> [Storage Implementation] Implement storage reader interface to fetch raw data
> from HBase backend
> ------------------------------------------------------------------------------------------------
>
> Key: YARN-3049
> URL: https://issues.apache.org/jira/browse/YARN-3049
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Sangjin Lee
> Assignee: Zhijie Shen
> Attachments: YARN-3049-WIP.1.patch, YARN-3049-WIP.2.patch,
> YARN-3049-WIP.3.patch, YARN-3049-YARN-2928.2.patch,
> YARN-3049-YARN-2928.3.patch, YARN-3049-YARN-2928.4.patch,
> YARN-3049-YARN-2928.5.patch, YARN-3049-YARN-2928.6.patch,
> YARN-3049-YARN-2928.7.patch
>
>
> Implement existing ATS queries with the new ATS reader design.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
