[
https://issues.apache.org/jira/browse/YARN-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14659012#comment-14659012
]
Li Lu commented on YARN-3049:
-----------------------------
Hi [~zjshen], letting HBase implementation locally looks good to me. One minor
comment for the latest patch is, maybe we want to separate the logic like {{if
(te.getType().equals(TimelineEntityType.YARN_APPLICATION.toString()))}} in
HBaseWriterImpl into a separate private method? I think it will be much clearer
to say something like:
{code}
if (te.getType().equals(TimelineEntityType.YARN_APPLICATION.toString())) {
updateAppToFlowTable(te);
}
{code}
As [~sjlee0] mentioned above that we may have some other specialization within
HBaseWriterImpl, so maybe it's helpful to let these special designs stand out?
> [Storage Implementation] Implement storage reader interface to fetch raw data
> from HBase backend
> ------------------------------------------------------------------------------------------------
>
> Key: YARN-3049
> URL: https://issues.apache.org/jira/browse/YARN-3049
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Sangjin Lee
> Assignee: Zhijie Shen
> Attachments: YARN-3049-WIP.1.patch, YARN-3049-WIP.2.patch,
> YARN-3049-WIP.3.patch, YARN-3049-YARN-2928.2.patch,
> YARN-3049-YARN-2928.3.patch, YARN-3049-YARN-2928.4.patch,
> YARN-3049-YARN-2928.5.patch, YARN-3049-YARN-2928.6.patch
>
>
> Implement existing ATS queries with the new ATS reader design.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
