Sangjin Lee commented on YARN-3049:

The latest patch looks good to me overall. Just a couple of comments.

I concur with [~gtCarrera9] that it might be a good idea to create more 
abstract methods around it. Note that we may be writing to other tables at this 
point too. We can even create private helper methods that check whether the 
entity is an application and so on. It's not critical but could be helpful...

Also, in {{HBaseTimelineWriterImpl}}, I see that the app-to-flow table is not 
being flushed. Either we should flush at the end of the write, or add it to the 
{{flush()}} method.

> [Storage Implementation] Implement storage reader interface to fetch raw data 
> from HBase backend
> ------------------------------------------------------------------------------------------------
>                 Key: YARN-3049
>                 URL: https://issues.apache.org/jira/browse/YARN-3049
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Sangjin Lee
>            Assignee: Zhijie Shen
>         Attachments: YARN-3049-WIP.1.patch, YARN-3049-WIP.2.patch, 
> YARN-3049-WIP.3.patch, YARN-3049-YARN-2928.2.patch, 
> YARN-3049-YARN-2928.3.patch, YARN-3049-YARN-2928.4.patch, 
> YARN-3049-YARN-2928.5.patch, YARN-3049-YARN-2928.6.patch
> Implement existing ATS queries with the new ATS reader design.

This message was sent by Atlassian JIRA

Reply via email to