Sunil G commented on YARN-4014:

Hi [~rohithsharma]
Thank you for sharing the patch. As discussed in YARN-3250, I also feel {{yarn 
application --appId <Applicationid> --setPriority <value>}} is fine. 

Few small nits:
1. In ApplicationCLI, {{public static final String SET_PRIORITY = 
Cud we use "UPDATE_PRIORITY" instead of "SET_PRIORITY"?
2. In future {{--appId}} can be used with other parameters also, correct? So 
below option may not be suitable.
opts.addOption(APP_ID, true, "Updates the priority of an application");
3. updateApplicationPriority can throw NumberFormatException.
4. ClientRMService.java has few commented code.

> Support user cli interface in for Application Priority
> ------------------------------------------------------
>                 Key: YARN-4014
>                 URL: https://issues.apache.org/jira/browse/YARN-4014
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: client, resourcemanager
>            Reporter: Rohith Sharma K S
>            Assignee: Rohith Sharma K S
>         Attachments: 0001-YARN-4014-V1.patch
> Track the changes for user-RM client protocol i.e ApplicationClientProtocol 
> changes and discussions in this jira.

This message was sent by Atlassian JIRA

Reply via email to