[
https://issues.apache.org/jira/browse/YARN-4014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14696594#comment-14696594
]
Sunil G commented on YARN-4014:
-------------------------------
Hi [~rohithsharma]
Thank you. Overall the patch looks good. Some minor nits
- In ApplicationClientProtocolPBServiceImpl, you may try like below
{code}
catch (YarnException | IOException e) {
throw new ServiceException(e);
}
{code}
- In ClientRMService
{code}
+ if (EnumSet.of(RMAppState.NEW, RMAppState.NEW_SAVING, RMAppState.FAILED,
+ RMAppState.FINAL_SAVING, RMAppState.FINISHING, RMAppState.FINISHED,
+ RMAppState.KILLED, RMAppState.KILLING, RMAppState.FAILED).contains(
+ application.getState()))
{code}
Could we have a lookup method for this rather checking it directly. May be
other apis can use this.
- In testUpdateApplicationPriorityRequest, Could we pass an invalid AppID and
check that error condition also.
- While printing message
{code}
+ pw.println(" -appId <Application ID> ApplicationId can be used
with any other");
+ pw.println(" sub commands in future.
Currently it is");
+ pw.println(" used along only with
-set-priority");
{code}
-set-priority can be changed to -updatePriority
> Support user cli interface in for Application Priority
> ------------------------------------------------------
>
> Key: YARN-4014
> URL: https://issues.apache.org/jira/browse/YARN-4014
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: client, resourcemanager
> Reporter: Rohith Sharma K S
> Assignee: Rohith Sharma K S
> Attachments: 0001-YARN-4014-V1.patch, 0001-YARN-4014.patch
>
>
> Track the changes for user-RM client protocol i.e ApplicationClientProtocol
> changes and discussions in this jira.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
