[ 
https://issues.apache.org/jira/browse/YARN-4014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14697761#comment-14697761
 ] 

Jian He commented on YARN-4014:
-------------------------------

some comments on my side:
- updateApplicationPriority has two RPC calls, one to get the appReport the 
other to update priority. Can we make it one call ? we can make 
updateApplicationPriority throw an ApplicationNotRunningException and let 
client catch the exception and prints “Application not running “ msg.
- I missed two things in YARN-3887, would you mind fixing those here ?
  -- the updateApplicationStateSynchronously should not send the 
APP_UPDATE_SAVED events and so RMAppImpl should not need handle this event as 
changed this patch. 
  -- CapacityScheduler#updateApplicationPriority should not be synchronized. 
it’ll cause problem if hold capacity scheduler lock while accessing 
state-store. 

> Support user cli interface in for Application Priority
> ------------------------------------------------------
>
>                 Key: YARN-4014
>                 URL: https://issues.apache.org/jira/browse/YARN-4014
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: client, resourcemanager
>            Reporter: Rohith Sharma K S
>            Assignee: Rohith Sharma K S
>         Attachments: 0001-YARN-4014-V1.patch, 0001-YARN-4014.patch
>
>
> Track the changes for user-RM client protocol i.e ApplicationClientProtocol 
> changes and discussions in this jira.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to