Naganarasimha G R commented on YARN-4058:

thanks [~sjlee0] for the review comments,
The reason for raising the application creation issue here was, the impact is 
more with our case as we are creating TimelineClient as part of application 
creation and further we might introduce some thread pools and queues inside 
TimelineClient for putAsync and other was a small issue with unused variable 
hence clubbed with other issues in this jira, if required i can segregate it. 

> Miscellaneous issues in NodeManager project
> -------------------------------------------
>                 Key: YARN-4058
>                 URL: https://issues.apache.org/jira/browse/YARN-4058
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Naganarasimha G R
>            Assignee: Naganarasimha G R
>            Priority: Minor
>         Attachments: YARN-4058.YARN-2928.001.patch
> # TestSystemMetricsPublisherForV2.testPublishApplicationMetrics is failing 
> # Unused ApplicationACLsManager in ContainerManagerImpl
> # In ContainerManagerImpl.startContainerInternal ApplicationImpl instance is 
> created and then checked whether it exists in context.getApplications(). 
> everytime ApplicationImpl is created state machine is intialized and 
> TimelineClient is created which is required only if added to the context.

This message was sent by Atlassian JIRA

Reply via email to