Naganarasimha G R commented on YARN-4044:

Hi [~sunilg],
I think overall the patch is fine just for few nits :
# In {{ApplicationHistoryManagerOnTimelineStore}} if check is not required as 
in any case we filling both Priority and QueueName when there is appupdate 
# We need to update the test case for 
{{ApplicationHistoryManagerOnTimelineStore}} modifications 

> Running applications information changes such as movequeue is not published 
> to TimeLine server
> ----------------------------------------------------------------------------------------------
>                 Key: YARN-4044
>                 URL: https://issues.apache.org/jira/browse/YARN-4044
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager, timelineserver
>    Affects Versions: 2.7.0
>            Reporter: Sunil G
>            Assignee: Sunil G
>            Priority: Critical
>         Attachments: 0001-YARN-4044.patch, 0002-YARN-4044.patch, 
> 0003-YARN-4044.patch
> SystemMetricsPublisher need to expose an appUpdated api to update any change 
> for a running application.
> Events can be 
>       - change of queue for a running application.
>         - change of application priority for a running application.
> This ticket intends to handle both RM and timeline side changes. 

This message was sent by Atlassian JIRA

Reply via email to