Varun Saxena commented on YARN-4075:

In addition to rebasing on latest branch code, patch has following changes :
* Removed userId as an optional query param from REST API for flows.
* 2 different REST API Endpoints, one with cluster and one without it.
* Take cluster id from config if not supplied by client.
* Instead of using TimelineMetric#toString, for the sake of clarity, wrote 2 
helper methods in test class to compare metrics.
* Added VisibleForTesting annotation for TimelineSchemaCreator#createAllTables. 
The method had been changed to public in updated code. Also, the class itself 
is marked as private.

I have not changed Set<TimelineEntity> to TimelineEntities as there are issues 
around deserializing a JSON to a POJO if a polymorphic collection is wrapped 
inside a class as is the case with TimelineEntities. I tried a few things but 
they did not work. Either each derived class will have to be named separately 
for deserialization or object mapper configurations will have to be changed. As 
this is not directly related to this JIRA, this problem should not block this 
JIRA. I can take care of this in some other JIRA.

> [reader REST API] implement support for querying for flows and flow runs
> ------------------------------------------------------------------------
>                 Key: YARN-4075
>                 URL: https://issues.apache.org/jira/browse/YARN-4075
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Sangjin Lee
>            Assignee: Varun Saxena
>         Attachments: YARN-4075-YARN-2928.03.patch, 
> YARN-4075-YARN-2928.POC.1.patch, YARN-4075-YARN-2928.POC.2.patch
> We need to be able to query for flows and flow runs via REST.

This message was sent by Atlassian JIRA

Reply via email to