[
https://issues.apache.org/jira/browse/YARN-3964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14907806#comment-14907806
]
Dian Fu commented on YARN-3964:
-------------------------------
Hi [~Naganarasimha],
Thanks a lot for your review. Have updated the patch according to your comments.
{quote}
CommonNodeLabelsManager.isDistributedNodeLabelConfiguration is set in
distributed mode and we avoid reading and storing to FileSystemNodeLabelsStore.
But in your case its not done, hence LabelStore Editlogs goes on increasing
over time as we not checking for weather the labels are not modified for a
given node while replacing. Eventually FileSystemNodeLabelsStore.recover during
startup(/failover) might be come slow.
{quote}
In fact, in delegated-centralized mode, we should also avoid storing the
node->labels map to FileSystemNodeLabelsStore. The new patch should have fixed
this.
{quote}
During update even if one node has Labels which is not part of CLuster Labels
it fails to update for other nodes is that fine ?
{quote}
This issue also exists when updating multiple nodes labels through CLI/REST.
Maybe we can address this in a separate JIRA if we think this is a problem.
> Support NodeLabelsProvider at Resource Manager side
> ---------------------------------------------------
>
> Key: YARN-3964
> URL: https://issues.apache.org/jira/browse/YARN-3964
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Dian Fu
> Assignee: Dian Fu
> Attachments: YARN-3964 design doc.pdf, YARN-3964.002.patch,
> YARN-3964.003.patch, YARN-3964.004.patch, YARN-3964.005.patch,
> YARN-3964.006.patch, YARN-3964.007.patch, YARN-3964.007.patch,
> YARN-3964.008.patch, YARN-3964.1.patch
>
>
> Currently, CLI/REST API is provided in Resource Manager to allow users to
> specify labels for nodes. For labels which may change over time, users will
> have to start a cron job to update the labels. This has the following
> limitations:
> - The cron job needs to be run in the YARN admin user.
> - This makes it a little complicate to maintain as users will have to make
> sure this service/daemon is alive.
> Adding a Node Labels Provider in Resource Manager will provide user more
> flexibility.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
