[ 
https://issues.apache.org/jira/browse/YARN-3964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14908489#comment-14908489
 ] 

Naganarasimha G R commented on YARN-3964:
-----------------------------------------

Hi [~sunilg],
Good points sunil, But i feel we can have different approach
bq. Is it better to check for yarn.node-labels.enabled also in 
DelegatedNodeLabelsUpdater init. 
Instead we can avoid creating DelegatedNodeLabelsUpdater in 
{{createDelegatedNodeLabelsUpdater}} if {{yarn.node-labels.enabled}} is set as 
false.
bq. createNodeLabelsMappingProvider throws exception from serviceInit if 
NodeLabelsMappingProvider class is not configured. 
If the configuration is explicitly set for delegated-centralized then i prefer 
to fail fast if provider is not configured properly, similarly what we plan to 
do in NM side when node labels script path are not configured but provider is 
set to script . Thoughts ?

> Support NodeLabelsProvider at Resource Manager side
> ---------------------------------------------------
>
>                 Key: YARN-3964
>                 URL: https://issues.apache.org/jira/browse/YARN-3964
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Dian Fu
>            Assignee: Dian Fu
>         Attachments: YARN-3964 design doc.pdf, YARN-3964.002.patch, 
> YARN-3964.003.patch, YARN-3964.004.patch, YARN-3964.005.patch, 
> YARN-3964.006.patch, YARN-3964.007.patch, YARN-3964.007.patch, 
> YARN-3964.008.patch, YARN-3964.1.patch
>
>
> Currently, CLI/REST API is provided in Resource Manager to allow users to 
> specify labels for nodes. For labels which may change over time, users will 
> have to start a cron job to update the labels. This has the following 
> limitations:
> - The cron job needs to be run in the YARN admin user.
> - This makes it a little complicate to maintain as users will have to make 
> sure this service/daemon is alive.
> Adding a Node Labels Provider in Resource Manager will provide user more 
> flexibility.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to