Naganarasimha G R commented on YARN-3964:

Thanks [~dian.fu],
For reworking on the comments, few nits & queries :
# DelegatedNodeLabelsUpdater
#* If updateInterval is disabled then only on register of nodes the labels are 
fetched, is that fine or is it better to fetch once and not run timer ?
#* Can there be chances that {{NodeLabelsMappingProvider}} requires 
configuration to initialize itself ? would it better to added it as service ?
#* {{updateNodeLabels(NodeId node)}} on exception we need to log with error 
instead of warn

> Support NodeLabelsProvider at Resource Manager side
> ---------------------------------------------------
>                 Key: YARN-3964
>                 URL: https://issues.apache.org/jira/browse/YARN-3964
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Dian Fu
>            Assignee: Dian Fu
>         Attachments: YARN-3964 design doc.pdf, YARN-3964.002.patch, 
> YARN-3964.003.patch, YARN-3964.004.patch, YARN-3964.005.patch, 
> YARN-3964.006.patch, YARN-3964.007.patch, YARN-3964.007.patch, 
> YARN-3964.008.patch, YARN-3964.1.patch
> Currently, CLI/REST API is provided in Resource Manager to allow users to 
> specify labels for nodes. For labels which may change over time, users will 
> have to start a cron job to update the labels. This has the following 
> limitations:
> - The cron job needs to be run in the YARN admin user.
> - This makes it a little complicate to maintain as users will have to make 
> sure this service/daemon is alive.
> Adding a Node Labels Provider in Resource Manager will provide user more 
> flexibility.

This message was sent by Atlassian JIRA

Reply via email to