[
https://issues.apache.org/jira/browse/YARN-3964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14910071#comment-14910071
]
Wangda Tan commented on YARN-3964:
----------------------------------
Thanks for updates, [~dian.fu]!
bq. Point2 is debatable, my 2 cents here is, if delegated-centralized was the
default i can agree, and if we have a default implementation which serves some
purpose like MemoryRMStateStore then fine, if not i am not too convinced to
create a dummy provider instance when user is explicitly setting
delegated-centralized, cc/ Wangda Tan ur thoughts ?
I would prefer to the fail-fast solution, since it is a configuration issue,
skip it may cause RM in an unexpected behavior. This is a little different from
RMStore failure, this is configuration issue and another one is runtime issue.
User should fix configuration before start RM.
Some comments:
- DelegatedNodeLabelsUpdater -> RMDelegatedNodeLabelsUpdater
- Add a comment to DelegatedNodeLabelsUpdater explains how it works and which
configuration controls enable it.
- NodeLabelsMappingProvider -> RMNodeLabelsMappingProvider
And I'm not sure if you noticed YARN-4106 and YARN-4176, I think the two issues
are related to what you're trying to do. Maybe it's better to consider them
within your patch.
> Support NodeLabelsProvider at Resource Manager side
> ---------------------------------------------------
>
> Key: YARN-3964
> URL: https://issues.apache.org/jira/browse/YARN-3964
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Dian Fu
> Assignee: Dian Fu
> Attachments: YARN-3964 design doc.pdf, YARN-3964.002.patch,
> YARN-3964.003.patch, YARN-3964.004.patch, YARN-3964.005.patch,
> YARN-3964.006.patch, YARN-3964.007.patch, YARN-3964.007.patch,
> YARN-3964.008.patch, YARN-3964.009.patch, YARN-3964.010.patch,
> YARN-3964.011.patch, YARN-3964.1.patch
>
>
> Currently, CLI/REST API is provided in Resource Manager to allow users to
> specify labels for nodes. For labels which may change over time, users will
> have to start a cron job to update the labels. This has the following
> limitations:
> - The cron job needs to be run in the YARN admin user.
> - This makes it a little complicate to maintain as users will have to make
> sure this service/daemon is alive.
> Adding a Node Labels Provider in Resource Manager will provide user more
> flexibility.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
