Jason Lowe commented on YARN-4132:

Thanks for updating the patch, Chang!

createRMProxy(conf, protocol, instance) should be implemented in terms of 
createRMProxy(retryTime, retryInterval, conf, protocol, instance) rather than 
copying the code.  It can do the conf lookups to get the retry values and call 
the other.  Then I don't see a need to check for -1 values.

".rm." should be ".resourcemanager.".  There's already precedent in the 
nodemanager.resourcemanager.minimum.version property.  Similarly "retry.ms" 
should be "retry-interval.ms" to be consistent with the existing 
resourcemanager properties.

The added test take a long time to run for just one test (around 25 seconds), 
please tune down the retry intervals.

Style nit: usually extra parameters for a function overload of an existing 
function are passed at the end of the other form.  Not a must-fix.

> Nodemanagers should try harder to connect to the RM
> ---------------------------------------------------
>                 Key: YARN-4132
>                 URL: https://issues.apache.org/jira/browse/YARN-4132
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Chang Li
>            Assignee: Chang Li
>         Attachments: YARN-4132.2.patch, YARN-4132.3.patch, YARN-4132.4.patch, 
> YARN-4132.patch
> Being part of the cluster, nodemanagers should try very hard (and possibly 
> never give up) to connect to a resourcemanager. Minimally we should have a 
> separate config to set how aggressively a nodemanager will connect to the RM 
> separate from what clients will do.

This message was sent by Atlassian JIRA

Reply via email to