Jason Lowe commented on YARN-4132:

Patch doesn't build.  Other comments:

Do we need to get rid of the old RMProxy.createRetryPolicy(conf) method?  We 
can just leave that around to reduce code churn on the patch and have it 
implemented in terms of the new createRetryPolicy method.

Similarly for maximum backwards compatibility we could leave around an 
RMProxy.createRMProxy method that doesn't take the extra values and calls the 
old createRetryPolicy method. A new private utility method, like 
createRMProxy(conf, protocol, instance, retryPolicy) could be added to factor 
out the common code between the two createRMProxy methods.

"to connection to RM" should be "to connect to the RM" in the property 
descriptions in yarn-default.xml.

> Nodemanagers should try harder to connect to the RM
> ---------------------------------------------------
>                 Key: YARN-4132
>                 URL: https://issues.apache.org/jira/browse/YARN-4132
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Chang Li
>            Assignee: Chang Li
>         Attachments: YARN-4132.2.patch, YARN-4132.3.patch, YARN-4132.4.patch, 
> YARN-4132.5.patch, YARN-4132.patch
> Being part of the cluster, nodemanagers should try very hard (and possibly 
> never give up) to connect to a resourcemanager. Minimally we should have a 
> separate config to set how aggressively a nodemanager will connect to the RM 
> separate from what clients will do.

This message was sent by Atlassian JIRA

Reply via email to