[ https://issues.apache.org/jira/browse/YARN-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Varun Vasudev updated YARN-1856: -------------------------------- Attachment: YARN-1856.002.patch bq. Could you move these constants to CGroupsHandler ? There are already some cgroups parameter constants defined there. Fixed. bq. IMO, If the behavior here is unpredictable, we should simply error our here in case both are enabled. Fixed. bq. We should make the fraction configurable, I think. What are the implications of the soft limit? Fixed. It's a lower limit useful when there's memory contention. bq. Since we are skipping changes to yarn-default.xml (based on changes I see in TestYarnConfigurationFields), these should be marked \@Private , similar to how network/disk configs settings are annotated? Fixed. bq. Thinking aloud here : should we add support in some form for memory.oom_control and notifications/stats? We should take that up as a separate JIRA. > cgroups based memory monitoring for containers > ---------------------------------------------- > > Key: YARN-1856 > URL: https://issues.apache.org/jira/browse/YARN-1856 > Project: Hadoop YARN > Issue Type: Sub-task > Components: nodemanager > Affects Versions: 2.3.0 > Reporter: Karthik Kambatla > Assignee: Varun Vasudev > Attachments: YARN-1856.001.patch, YARN-1856.002.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)