[ 
https://issues.apache.org/jira/browse/YARN-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Vasudev updated YARN-1856:
--------------------------------
    Attachment: YARN-1856.003.patch

bq. The constants should have ‘MEMORY’ in their names. For example, 
CGROUP_PARAM_HARD_LIMIT is better named as CGROUP_PARAM_MEMORY_HARD_LIMIT in 
order to avoid future collisions. This is similar to how BLKIO is used in the 
previous line (classid should be fixed at some point too)

Fixed.

bq. Is the soft limit conf setting meant to represent a percentage or is it a 
fraction between 0 and 1? From the default value of 0.9f and the application of 
the soft limit it appears to be a fraction, but the name of the setting and its 
validation check seem to indicate that it is meant to be a percentage. This 
needs to be fixed.

Good catch. It's meant to be a percentage. Fixed.

> cgroups based memory monitoring for containers
> ----------------------------------------------
>
>                 Key: YARN-1856
>                 URL: https://issues.apache.org/jira/browse/YARN-1856
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager
>    Affects Versions: 2.3.0
>            Reporter: Karthik Kambatla
>            Assignee: Varun Vasudev
>         Attachments: YARN-1856.001.patch, YARN-1856.002.patch, 
> YARN-1856.003.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to