[
https://issues.apache.org/jira/browse/YARN-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Varun Vasudev updated YARN-1856:
--------------------------------
Attachment: YARN-1856.004.patch
{quote}
Should add all the configs to yarn-default.xml, saying they are still early
configs?
{quote}
I don't think we've figured out how to specify the various resource isolation
pieces from a config perspective. I'd like to keep to private for now and I'll
file a follow up JIRA to document the configs once we've figured it out. The
remaining points all relate to this so I'll address them when as part of that
JIRA.
{quote}
ResourceHandlerModule - Formatting of new code is a little off: the declaration
of getCgroupsMemoryResourceHandler(). There are other occurrences like this in
that class before in this patch, you may want to fix those.
{quote}
Fixed.
{quote}
BUG! getCgroupsMemoryResourceHandler() incorrectly locks
DiskResourceHandler instead of MemoryResourceHandler.
CGroupsMemoryResourceHandlerImpl
{quote}
Not a bug! But a *bad* typo nonetheless. Fixed
{quote}
What is this doing? {{ CGroupsHandler.CGroupController MEMORY =
CGroupsHandler.CGroupController.MEMORY; }} Is it forcing a class-load or
something? Not sure if this is needed. If this is needed, you may want to add a
comment here.
{quote}
No just a shorthand instead of specifying the entire qualified variable every
time.
{quote}
NM_MEMORY_RESOURCE_CGROUPS_SOFT_LIMIT_PERC ->
NM_MEMORY_RESOURCE_CGROUPS_SOFT_LIMIT_PERCENTAGE. Similarly the default
constant.
{quote}
Fixed.
{quote}
CGROUP_PARAM_MEMORY_HARD_LIMIT_BYTES / CGROUP_PARAM_MEMORY_SOFT_LIMIT_BYTES
/ CGROUP_PARAM_MEMORY_SWAPPINESS can all be static and final.
{quote}
Interface variables are public static final by default. Any reason you want to
add static final?
> cgroups based memory monitoring for containers
> ----------------------------------------------
>
> Key: YARN-1856
> URL: https://issues.apache.org/jira/browse/YARN-1856
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager
> Affects Versions: 2.3.0
> Reporter: Karthik Kambatla
> Assignee: Varun Vasudev
> Attachments: YARN-1856.001.patch, YARN-1856.002.patch,
> YARN-1856.003.patch, YARN-1856.004.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
