[ https://issues.apache.org/jira/browse/YARN-4238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15054333#comment-15054333 ]
Naganarasimha G R commented on YARN-4238: ----------------------------------------- Hi [~varun_saxena], Thanks for working on this issue, overall i feel the patch is fine but just requires rebase based on changes of YARN-4356. Also one basic question related to the structure of *TimelineEntity* (Sorry for putting this across now!), will there be any advantage of {{modified time}} ? If not used as part of any query then better to avoid storing it as in some entities it will be a disadvantage, for example in case of {{ContainerEntity}} we are updating the modified time for each container usage report, unnecessary updates will happen in the backend, Correct me if i my understanding is wrong. Also would like to take shot in committing this patch once the rebase is done, if no one has concerns ! > createdTime and modifiedTime is not reported while publishing entities to > ATSv2 > ------------------------------------------------------------------------------- > > Key: YARN-4238 > URL: https://issues.apache.org/jira/browse/YARN-4238 > Project: Hadoop YARN > Issue Type: Sub-task > Components: timelineserver > Affects Versions: YARN-2928 > Reporter: Varun Saxena > Assignee: Varun Saxena > Labels: yarn-2928-1st-milestone > Attachments: YARN-4238-YARN-2928.01.patch, > YARN-4238-feature-YARN-2928.002.patch, YARN-4238-feature-YARN-2928.02.patch, > YARN-4238-feature-YARN-2928.03.patch, YARN-4238-feature-YARN-2928.04.patch > > > While publishing entities from RM and elsewhere we are not sending created > time. For instance, created time in TimelineServiceV2Publisher class and for > other entities in other such similar classes is not updated. We can easily > update created time when sending application created event. Likewise for > modification time on every write. -- This message was sent by Atlassian JIRA (v6.3.4#6332)