[ 
https://issues.apache.org/jira/browse/YARN-4238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15054938#comment-15054938
 ] 

Naganarasimha G R commented on YARN-4238:
-----------------------------------------

Hi [~varun_saxena], 
Thanks for updating on the info.
bq. Yes its used to filter rows during query at the reader side.
If its used then fine, but would the query be helpful if its based on 
modification time ? i thought it will be based on creation time but if required 
then fine.
bq. Modified time is only updated when we write an event. Also we do writes in 
a batch. Modified time is only 8 bytes. I dont think that theoretically this 
should cause any bottleneck.
yeah theoretically should be fine but it might be little more than 8 bytes as 
its in hbase(Key value etc...) and for large number containers in a large 
cluster thought might be unnecessary. Also If its in batch then little better 
but would like to know the views of others here .
bq. Which patch would you want ? With the checkstyle issue in 
JobHistoryEventHandler fixed(which would include changing unrelated code as 
well) or without them fixed ?
As [~djp] mentioned my opinion too is to better to be *not handled* here, as as 
there is already one more jira and can be taken care there. 



> createdTime and modifiedTime is not reported while publishing entities to 
> ATSv2
> -------------------------------------------------------------------------------
>
>                 Key: YARN-4238
>                 URL: https://issues.apache.org/jira/browse/YARN-4238
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Varun Saxena
>            Assignee: Varun Saxena
>              Labels: yarn-2928-1st-milestone
>         Attachments: YARN-4238-YARN-2928.01.patch, 
> YARN-4238-feature-YARN-2928.002.patch, YARN-4238-feature-YARN-2928.02.patch, 
> YARN-4238-feature-YARN-2928.03.patch, YARN-4238-feature-YARN-2928.04.patch
>
>
> While publishing entities from RM and elsewhere we are not sending created 
> time. For instance, created time in TimelineServiceV2Publisher class and for 
> other entities in other such similar classes is not updated. We can easily 
> update created time when sending application created event. Likewise for 
> modification time on every write.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to