Varun Saxena commented on YARN-4238:

Thanks [~Naganarasimha] for the review.
You can take a shot at committing this and verify if you have push rights :)

Coming to the comments.
bq. will there be any advantage of modified time ?
Yes its used to filter rows during query at the reader side.

bq.  unnecessary updates will happen in the backend
Modified time is only updated when we write an event. Also we do writes in a 
batch. Modified time is only 8 bytes. I dont think that theoretically this 
should cause any bottleneck. cc [~vrushalic]

I will rebase. 
Which patch would you want ? With the checkstyle issue in 
JobHistoryEventHandler fixed(which would include changing unrelated code as 
well) or without them fixed ?
Depends on what you would find easier to review.
Do let me know. 

> createdTime and modifiedTime is not reported while publishing entities to 
> ATSv2
> -------------------------------------------------------------------------------
>                 Key: YARN-4238
>                 URL: https://issues.apache.org/jira/browse/YARN-4238
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Varun Saxena
>            Assignee: Varun Saxena
>              Labels: yarn-2928-1st-milestone
>         Attachments: YARN-4238-YARN-2928.01.patch, 
> YARN-4238-feature-YARN-2928.002.patch, YARN-4238-feature-YARN-2928.02.patch, 
> YARN-4238-feature-YARN-2928.03.patch, YARN-4238-feature-YARN-2928.04.patch
> While publishing entities from RM and elsewhere we are not sending created 
> time. For instance, created time in TimelineServiceV2Publisher class and for 
> other entities in other such similar classes is not updated. We can easily 
> update created time when sending application created event. Likewise for 
> modification time on every write.

This message was sent by Atlassian JIRA

Reply via email to