Sangjin Lee commented on YARN-4238:

Thanks [~varun_saxena] for the summary, and [~Naganarasimha] for bringing up 
the matter.

To elaborate on a couple of points, although the modified time was introduced 
early in the data model, I don't think we had things like queries based on the 
modified time in mind. It was suggested more for the usefulness in terms of 
troubleshooting ("when was the entity last written to?"), but not much more. 
One analogy may be the often-present modified timestamp columns in SQL tables.

Other than that, I'm generally agreeing with Varun's summary. At minimum, the 
modified timestamp should not be set by clients. And we should probably drop 
the modified time from the schema in general. We can leave it in the data 
model, but I'm still not 100% sure if we even need to bother with that. I'd 
like to hear your thoughts.

> createdTime and modifiedTime is not reported while publishing entities to 
> ATSv2
> -------------------------------------------------------------------------------
>                 Key: YARN-4238
>                 URL: https://issues.apache.org/jira/browse/YARN-4238
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Varun Saxena
>            Assignee: Varun Saxena
>              Labels: yarn-2928-1st-milestone
>         Attachments: YARN-4238-YARN-2928.01.patch, 
> YARN-4238-feature-YARN-2928.002.patch, YARN-4238-feature-YARN-2928.003.patch, 
> YARN-4238-feature-YARN-2928.02.patch
> While publishing entities from RM and elsewhere we are not sending created 
> time. For instance, created time in TimelineServiceV2Publisher class and for 
> other entities in other such similar classes is not updated. We can easily 
> update created time when sending application created event. Likewise for 
> modification time on every write.

This message was sent by Atlassian JIRA

Reply via email to