Varun Saxena commented on YARN-4238:

Quick update based on the discussion we had in call.

We decided to hold off committing this JIRA for a while.  Based on today's 
discussion scope of this JIRA will change a bit and will have to change the 
title accordingly  as well.
Coming to the discussion,
# Created time would still be updated from the client.
# We discussed what modified time actually means and what it has to be used 
for. And should we rely on client filling it or server should fill it. It came 
across that modified time was kept as part of the entity for mainly debugging 
purposes. And it makes more sense from a debugging perspective to know when was 
a particular Put was made into HBase then the value reported by client.
# As per discussion till now, modified time can although be filled by the 
client, it will be ignored by the server. And HBase cell timestamp will be used 
to fill the modified time in the entity response. As part of this proposal, we 
will drop the modified time column from the entity and application table. And 
will fill the modified time based on the cells returned(in terms of entity, 
based on fields returned). 
One point to ponder upon here is though that on reader side we filter rows 
based on modified time. Currently its done after fetching records from HBase. 
If we get modified time like this, the filtering based on it will again be on 
the basis of fields to return rather than overall entity's modified time.

cc [~sjlee0], [~jrottinghuis], [~vrushalic]. Anything more you want to add ?

Naga, you can discuss with me offline for details.

> createdTime and modifiedTime is not reported while publishing entities to 
> ATSv2
> -------------------------------------------------------------------------------
>                 Key: YARN-4238
>                 URL: https://issues.apache.org/jira/browse/YARN-4238
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Varun Saxena
>            Assignee: Varun Saxena
>              Labels: yarn-2928-1st-milestone
>         Attachments: YARN-4238-YARN-2928.01.patch, 
> YARN-4238-feature-YARN-2928.002.patch, YARN-4238-feature-YARN-2928.003.patch, 
> YARN-4238-feature-YARN-2928.02.patch
> While publishing entities from RM and elsewhere we are not sending created 
> time. For instance, created time in TimelineServiceV2Publisher class and for 
> other entities in other such similar classes is not updated. We can easily 
> update created time when sending application created event. Likewise for 
> modification time on every write.

This message was sent by Atlassian JIRA

Reply via email to