[
https://issues.apache.org/jira/browse/YARN-4512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15091190#comment-15091190
]
Inigo Goiri commented on YARN-4512:
-----------------------------------
A couple comments on the patch:
# Some places (e.g., {{YarnConfiguration}}) still use Oversubscription. I
prefer that term but according to the discussion it should be Overallocation
everywhere.
# I would keep the old {{NodeStatus}} initializer with default Overallocation;
this would reduce the changes in the unit tests.
# Should we differentiate physical and virtual memory thresholds?
# In the {{NodeStatus}} proto should we directly use {{optional
ResourceThresholdsProto over_allocation_info = 9}} instead of {{optional
OverAllocationInfoProto over_allocation_info = 9}}. What would be the use of
{{OverAllocationInfoProto}}?
# {{MAX_NM_OVERSUBSCRIPTION_ALLOCATION_THRESHOLD}} should be used when reading
the oversubscription/overallocation parameter and show some log if passed,
right?
# Should the RM know about the {{preemptionThreshold}}
> Provide a knob to turn on over-allocation
> -----------------------------------------
>
> Key: YARN-4512
> URL: https://issues.apache.org/jira/browse/YARN-4512
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager
> Reporter: Karthik Kambatla
> Assignee: Karthik Kambatla
> Attachments: YARN-4512-YARN-1011.001.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
